As you may imagine, preference is given to participants in the Asterisk project who choose to participate in the entire patch process.Īs such, you are highly encouraged to submit your patch to Gerrit. Hence, when you don't put your patch up for review, you place the burden on others to review your code for you. However, all patches made to Asterisk are peer reviewed. Attaching your patch as a code contribution to an issue in JIRA is all that is required. Do I have to put my patch up for code review?.This includes not only review of your patch, but review of other patches as well. If you have not put the patch up for code review, your issue will be handled by an Asterisk developer as time and resources permits.Īll users who have signed a license contributor agreement have access to Gerrit and are encouraged to participate in the peer review process. If you have put the patch up for code review on Gerrit, the patch will be reviewed there and - if accepted - merged into the project and the issue closed. Not Preferred: attach the patch to the issue in unified diff format, marking the patch as a code contribution.Īfter you contribute a patch, bug marshals will triage the issue per the Issue Tracker Workflow.Please follow the instructions on the Code Review and Gerrit Usage pages for submitting the patch to Gerrit. Highly Preferred: Submit the patch for code review to Gerrit, referencing the created issue in the topic field.Create a new Git branch for your change, and implement your change.īefore submitting the patch, make sure your patch conforms to the Asterisk project Coding Guidelines.Since you'll need to put your patch up for review, make an account in Gerrit as well, following the instructions on Gerrit Usage. Obtain the Asterisk source code from Gerrit.

Please read the Asterisk Issue Guidelines for information on filing an issue. Create a new issue in the Asterisk project issue tracker for the bug or new feature.Sign a Contributor License Agreement in the Asterisk issue tracker.Create an account with the Asterisk project at.

Project patch reviews